Conversation
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 89.38% 90.66% +1.28%
==========================================
Files 185 189 +4
Lines 5631 5915 +284
Branches 1336 1420 +84
==========================================
+ Hits 5033 5363 +330
+ Misses 590 545 -45
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
wewoor
reviewed
Nov 15, 2021
mortalYoung
force-pushed
the
feat/split
branch
from
c24d7d3 to
47327d3
Compare
mortalYoung
changed the title
Collaborator
|
@mortalYoung 试了下，Workbench 面板 Resize 好像出不来，Outline 面板可以无限制拖动 |
Collaborator
Author
resize 修复了，Panel 这块因为没有 minSize 和 maxSize 设置，所以可以无限制的拖动 |
wewoor
requested changes
Nov 22, 2021
wewoor
changed the title
Collaborator
|
@mortalYoung |
mortalYoung
force-pushed
the
feat/split
branch
from
f46ef27 to
43853ee
Compare
* refactor: use built-in splitPane component in collapse and editor * feat: improve collapse * feat: support resize strategy for Split Pane * test: update tests * test: add unit tests for Collapse Component
mortalYoung
force-pushed
the
feat/split
branch
from
a2d600b to
4888356
Compare
Collaborator
Author
done！ |
mortalYoung
changed the title
kiwiwong
reviewed
Feb 23, 2022
Collaborator
kiwiwong
left a comment
kiwiwong
left a comment
There was a problem hiding this comment.
调整panel的大小时，group的大小也会变。
wewoor
reviewed
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
简介
react-split-pane主要变更
SplitPane组件请先合并 #510 的内容到本分支，再把本分支合并至 main 分支
Related Issues
Closed #644 #407