fix: Connect component supports to unsubscribe event by pass the callback#635
Merged
fix: Connect component supports to unsubscribe event by pass the callback#635
Conversation
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 184 184
Lines 5412 5418 +6
Branches 1222 1224 +2
==========================================
+ Hits 4818 4824 +6
Misses 586 586
Partials 8 8
Continue to review full report at Codecov.
|
mortalYoung
requested changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
修复
connectService 多次后,组件销毁后,导致事件无效的问题Fixes #596
Changes
EventEmitter支持通过事件name和callback函数引用取消订阅connectHOC 组件,按callback取消事件订阅How Has This Been Tested?