Skip to content

fix: sync menuBar mode status#637

Merged
wewoor merged 1 commit intomainfrom
fix/menuBar-mode
Jan 20, 2022
Merged

fix: sync menuBar mode status#637
wewoor merged 1 commit intomainfrom
fix/menuBar-mode

Conversation

@kiwiwong
Copy link
Copy Markdown
Collaborator

Description

Fix the problem that the MenuBar mode status is out of sync.

Fixes #626

Changes

  • Use event subscription to update menuBar data
  • Add a case of modifying the MenuBar mode in TestPanel

@kiwiwong kiwiwong added the bug Something isn't working label Jan 20, 2022
@kiwiwong kiwiwong self-assigned this Jan 20, 2022
Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2022

Codecov Report

Merging #637 (0f01729) into main (f355c88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #637   +/-   ##
=======================================
  Coverage   89.02%   89.03%           
=======================================
  Files         184      184           
  Lines        5412     5415    +3     
  Branches     1222     1222           
=======================================
+ Hits         4818     4821    +3     
  Misses        586      586           
  Partials        8        8           
Impacted Files Coverage Δ
src/model/workbench/menuBar.ts 100.00% <ø> (ø)
src/controller/menuBar.ts 100.00% <100.00%> (ø)
src/services/workbench/layoutService.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f355c88...0f01729. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit ecdb312 into main Jan 20, 2022
@wewoor wewoor deleted the fix/menuBar-mode branch January 20, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: sync menuBar horizontal mode status

2 participants