Skip to content

feat: support to set the expandKeys#664

Merged
wewoor merged 2 commits intomainfrom
feat/expandKeys
Feb 24, 2022
Merged

feat: support to set the expandKeys#664
wewoor merged 2 commits intomainfrom
feat/expandKeys

Conversation

@mortalYoung
Copy link
Copy Markdown
Collaborator

简介

  • folderTree 支持设置 expandKeys

主要变更

  • folderTreeModel 支持 expandKeys
  • folderTreeService 支持 set 和 get 方法,同时抛出 onExpandKeys 方法
  • folderTreeController 支持 onExpandKeys,支持 emit expand 事件

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2022

Codecov Report

Merging #664 (432a3ef) into main (f5e3a35) will increase coverage by 0.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         185      185           
  Lines        5638     5649   +11     
  Branches     1338     1339    +1     
=======================================
+ Hits         5061     5071   +10     
- Misses        570      571    +1     
  Partials        7        7           
Impacted Files Coverage Δ
src/components/tree/index.tsx 98.97% <ø> (ø)
src/model/workbench/explorer/folderTree.tsx 92.59% <ø> (ø)
src/extensions/folderTree/index.tsx 82.75% <50.00%> (-2.43%) ⬇️
src/controller/explorer/folderTree.tsx 100.00% <100.00%> (ø)
...c/services/workbench/explorer/folderTreeService.ts 99.44% <100.00%> (+0.02%) ⬆️
src/workbench/sidebar/explore/folderTree.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e3a35...432a3ef. Read the comment docs.

@mortalYoung mortalYoung self-assigned this Feb 23, 2022
@mortalYoung mortalYoung added this to the 0.9.0-beta.4 milestone Feb 23, 2022
@mortalYoung mortalYoung linked an issue Feb 23, 2022 that may be closed by this pull request
@wewoor wewoor requested review from kiwiwong and wewoor and removed request for wewoor February 24, 2022 03:03
Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Collaborator

@kiwiwong kiwiwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit e9a8cdd into main Feb 24, 2022
@wewoor wewoor deleted the feat/expandKeys branch February 24, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: FolderTree supports to set the ExpandKeys

3 participants