Skip to content

fix: move the style of statusBarView into mo.scss#689

Merged
wewoor merged 1 commit intomainfrom
fix/scss
Mar 4, 2022
Merged

fix: move the style of statusBarView into mo.scss#689
wewoor merged 1 commit intomainfrom
fix/scss

Conversation

@mortalYoung
Copy link
Copy Markdown
Collaborator

@mortalYoung mortalYoung commented Mar 4, 2022

简介

  • 修复样式文件丢失的报错

主要变更

  • scss 样式文件通过 style/mo.scss 内引入,而不是在组件内引用

@mortalYoung mortalYoung requested a review from wewoor March 4, 2022 07:13
@mortalYoung mortalYoung self-assigned this Mar 4, 2022
@mortalYoung mortalYoung added the bug Something isn't working label Mar 4, 2022
@mortalYoung mortalYoung added this to the 0.9.0-beta.4 milestone Mar 4, 2022
@wewoor wewoor changed the title fix: fix lost scss in notification fix: move the style of statusBarView into mo.scss Mar 4, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2022

Codecov Report

Merging #689 (defe415) into main (a88a71e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files         189      189           
  Lines        5943     5943           
  Branches     1429     1429           
=======================================
  Hits         5398     5398           
  Misses        538      538           
  Partials        7        7           
Impacted Files Coverage Δ
src/workbench/notification/statusBarView/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88a71e...defe415. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 08d799b into main Mar 4, 2022
@wewoor wewoor deleted the fix/scss branch March 4, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants