Skip to content

fix: remove invalid Regex in Safari#777

Merged
wewoor merged 1 commit intomainfrom
fix/invalidRegxInSafari
Jul 12, 2022
Merged

fix: remove invalid Regex in Safari#777
wewoor merged 1 commit intomainfrom
fix/invalidRegxInSafari

Conversation

@wewoor
Copy link
Copy Markdown
Collaborator

@wewoor wewoor commented Jul 12, 2022

Description

移除 Safari 中不支持的正则,具体参考:

Fixes #776

Changes

  • 移除反向肯定预查条件

@wewoor wewoor requested a review from mortalYoung July 12, 2022 06:03
@wewoor wewoor added the bug Something isn't working label Jul 12, 2022
@wewoor wewoor changed the title fix: remove invalid Regex for Safari fix: remove invalid Regex in Safari Jul 12, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 12, 2022

Codecov Report

Merging #777 (ae720b0) into main (32c877a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         191      191           
  Lines        5869     5869           
  Branches     1405     1405           
=======================================
  Hits         5379     5379           
  Misses        484      484           
  Partials        6        6           
Impacted Files Coverage Δ
...c/services/workbench/explorer/folderTreeService.ts 99.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c877a...ae720b0. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 66da95e into main Jul 12, 2022
@wewoor wewoor deleted the fix/invalidRegxInSafari branch July 12, 2022 06:32
@xu4wang
Copy link
Copy Markdown

xu4wang commented Jul 12, 2022

+1

期待早日可以在ipad/iphone上测起来

@xu4wang
Copy link
Copy Markdown

xu4wang commented Jul 13, 2022

WechatIMG1426

Seems working now on my iPhone. Congrats @wewoor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: UI doesn't show up on Safari/MacOS, Chrome/iPad and Safari/iOS

3 participants