perf(compiler): extend x86 cg peephole rules#437
Closed
abmcar wants to merge 6 commits into
Closed
Conversation
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
abmcar
force-pushed
the
perf/x86-cg-peephole-rules
branch
2 times, most recently
from
5c5941f to
a30d58d
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add comments for intentional design decisions (ZeroToErase asymmetry, TEST dual-trigger, NoOpImm whitelist) - Use SmallVector for small peephole collections to avoid heap allocs - Add function-level pattern descriptions for complex match functions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- matchDirectBoolBranch: note optional or-with-zero and direct self-test path - matchCmovBoolBranch: note order-independent mov defs, cmp/test output Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
abmcar
force-pushed
the
perf/x86-cg-peephole-rules
branch
from
a30d58d to
3f4c8c4
Compare
Contributor
Author
|
Closing in favor of PR #439 ( Both PRs branched from the same main commit and both touch The 988-line implementation from this branch was already ported to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/compiler/target/x86/x86_cg_peephole.cppand.hValidation
tools/format.sh check./build/evmStateTests --gtest_brief=1Benchmark
Latest reliable local
external/totalcomparison against the previous stable candidate:1.069xmain/*:1.023xmicro/*:1.012xsynth/*:1.078xLargest wins in that run:
external/total/synth/GAS/a0,a1: about2.36xto2.41xexternal/total/micro/memory_grow_mstore/by32: about1.82xexternal/total/micro/memory_grow_mload/by32: about1.55xKnown regressions remain concentrated in a small set of micro cases:
memory_grow_mload/nogrowmemory_grow_mload/by1memory_grow_mstore/nogrowmemory_grow_mstore/by1memory_grow_mstore/by16jump_around/loop_with_many_jumpdests/signextendcases