Removed unneeded capsys argument to integtest function calls; added --pytest-options argument to the bundle script#294
Merged
eflumerf merged 3 commits intoeflumerf/SkipResourceChecksfrom Feb 17, 2026
Conversation
added 3 commits
February 17, 2026 08:18
…ption with --pytest-options so that we can support multiple options to be passed to pytest, and added the -rs option to pytes when --concise is specified so that we continue to see any messages about skipped tests after skipping has been moved into the integrationtest infrastructure.
Merged
4 tasks
eflumerf
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes are minor tweaks to the changes that Eric made in #293. They are based on Eric's branch, and they are related to DUNE-DAQ/integrationtest#145.
Eric,
I like the spirit of your changes.
Two things that I felt were lost (and I would like to get back) were
required_resources_reportwhen a test is skipped and the--conciseoption is passed to the bundle script or the "-s" option is not given topytestitselfrecommended_resources_reportat the end of the console output from a test (so that users don't have to scroll back to see it)In the first case, I made modifications in the
integrationtestrepo and in thedunedaq_integtest_bundle.shscript to recover the message when--conciseis used. I don't yet have a solution for the case when a user runspytestdirectly and omits the "-s".For the second case, I just added a second printout of
recommended_resources_reportafter the "yield" incheck_system_resources.Another change that I felt would be useful was to switch from using a
--skip-resource-checkoption in the bundle script to using a--pytest-optionsoption. I know of an additional option that would be nice to pass to pytest (the process manager type), and it seems reasonable to simply give users a hook to pass all the options that they want to pass through the bundle script instead of trying to add support for each one. This change is part of this PR.Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)Further checks