Added an hdf5_compression_test and restored a couple of the existing tests#415
Merged
bieryAtFnal merged 18 commits intoJun 9, 2025
Merged
Conversation
…(none) to pytest.ini.
… v5 software and infrastructure, and to add in features that we like from the daqsystemtest bundle script.
…and large_trigger_record_test.py a bit. These integtests may not be fully operational in v5, though.
…lect its current purpose, updated some variable names inside it, and added the cleanup of TP Stream files after the test completes.
…lect its current purpose, updated some variable names inside it, and added the cleanup of TP Stream files after the test completes.
…ata writers in a single Dataflow App. (This functionality accidentally got lost in the conversion form v4 to v5.)
…p data files in various integtests.
… wrong number of files is produced.
…n specify tests by name substrings)
…iple_data_writers_test.py
…mods to this integtest to get it to run more reliably (e.g. larger tp_input queue).
….py, to try to avoid occasional failures to push data onto that queue.
Collaborator
Author
|
Not surprisingly, if we locally-modify the This is good news, and a nice confirmation that the test is doing some meaningful checks, IMO. |
Collaborator
Author
|
Here are suggested instructions for creating a software area and running a test: |
andrewmogan
approved these changes
Jun 4, 2025
Contributor
andrewmogan
left a comment
There was a problem hiding this comment.
I ran the dfmodules test bundle as suggested and can confirm all the tests pass. I also see that, if I set the compression_level to 0 for either stream, I get the appropriate error corresponding to too many files being created due to exceeding the maximum file size. Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to add an integration test to verify the correct operation of the HDF5 compression code. The new test is called
hdf5_compression_test.py.As part of improving the
dfmodulesintegtest generally, the v4multi_output_file_test.pyhas been split intomax_file_size_test.pyandmultiple_data_writers_test.py, both of which are now operational in v5.x. Several of the other existing tests still need to be updated for v5.There were also some read-ability changes to integtests, copied from ones in the
daqsystemtestrepo. And, there were some updates to thedfmodules_integtest_bundle.shscript, copying improvements from the similar script indaqsystemtest.To test these changes, I recommend running the 3 available integtests multiple times, such as with a command like
dfmodules_integtest_bundle.sh -N 3 --stop-on-fail.I'll post instructions soon for creating a software area to test these changes.