Add verbose error#416
Merged
Merged
Conversation
bieryAtFnal
approved these changes
Jun 9, 2025
Collaborator
bieryAtFnal
left a comment
bieryAtFnal
left a comment
There was a problem hiding this comment.
LGTM. I locally modified the FragAgg code to occasionally produce the updated error message in a fake-data-replay system, and it looked good. I also successfully ran the regression tests in the daqsystemtest repo.
Contributor
Author
|
Great, I'll merge and add to the local build in EHN1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the fragment aggregator fails to send, the issue is reported as a warning which is not descriptive because we don't have any information about the what is lost. We only know what error was reported by the iomanager. This is the typical example of what is seen.
This PRs turns the warning into an error, as there is data loss and it also adds a dedicated ERS message to specify what was lost.
This is a screenshot of the message that we see after the PR.