Conversation
chenel
requested changes
Jul 10, 2025
Collaborator
chenel
left a comment
chenel
left a comment
There was a problem hiding this comment.
most of the way there, I think, but still a few issues
Member
Author
|
Good news, I've fixed some more issues and it seems to work well now. Sample of 10 test files available at: Edit: Changing to active PR |
chenel
approved these changes
Jul 21, 2025
Collaborator
chenel
left a comment
chenel
left a comment
There was a problem hiding this comment.
Given that you're happy with the output, I'll approve. I don't see any obvious problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added true variable definitions in TMS reco filler header.
Correctly associate truth tracks to reco in the CAF output.
Fixed an indexing bug in TMS Reco Filler that resulting on most tracks having NaN values.
Changed fcl config variable names to reflect those that CAFMaker tries to read, including working example for MicroProdP4n1.