Conversation
…al. Still needs some love
…iller, probably fixing a typo here
…ind any other way of checking which reco a class was
…eds some love, and would be good to add the physical (cm) track length to output in TMS reco
Added TMS-NDLAr matching code.
Added TMS-NDLAr matching code.
Added TMS-NDLAr matching code.
…ove this over time though since it also builds edep-sim which is now a ups product
cjbacchus
left a comment
There was a problem hiding this comment.
Looks basically sane to me. We decided to sequence this after the similar SAND merge since they will likely slightly conflict.
chenel
left a comment
There was a problem hiding this comment.
generally ok---a few suggestions and questions but once Chris's comments are addressed I think we're ready to merge
… to the SAND branch merge.
|
I pushed the fixes that make this work with the newly-merged SAND branch |
|
Is someone working on the most major of the comments above? |
|
@cjbackhouse I plan to address them either today or over the weekend. I agree with all the above comments for what it's worth. Faiza is updating the track matcher so I'll wait for her and let you know |
…into the TMS instead of propagating both tracks into the gap between LAr and TMS; this choice was made because trusting the direction vector of a bending track in the TMS isnt the best idea). Also update method of not relying on TF1, instead just doing the arithmetic in the code. Also move to doubles instead of floats. And allow for multiple TMS tracks to match a single LAr track and vice versa; dont stop looking for matches after one is found
|
Branch is now updated with a few additions:
Found some bugs during this; the LAr direction vectors appear to be corrupted. Hence the matching calculates the line in LAr by using start and end points of the LAr track rather than the saved direction vector. This should be updated when the LAr unit vectors are fixed. |
…e mighty FNAL lords intended
|
I think we are in a position to merge this (the ND-LAr bug above is not related to anything in this repo and will be fixed next time we respin). @clarenc3 would you do the honors? |
|
Turns out @clarenc3 is |
TMS reco/matching merge