Skip to content

Fprompt multi hit #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jvmead wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

Fprompt multi hit #229

jvmead wants to merge 32 commits into from

Conversation

@jvmead
Copy link
Member

@jvmead jvmead commented Dec 8, 2025

  • fixing bug in fprompt for multi-hit events
  • generalised to sipm and sum hit level
  • made adaptive baselining parameter to flexibly handle different waveform lengths

includes:

doesn't include:

jvmead and others added 30 commits September 30, 2025 02:34
@jvmead
baseline fix (abs on np.ptp output and zero mask
3112f3c
@jvmead
feeding RMS from wvfm filter (baseline function) stage through to sum…
34422e1 
…ming of waveforms and hit finder thresholds to replace MAD mask method
@jvmead
ongoing bug fixing for passing rms forward to hitfinder
6e2874a
@jvmead
changing settings so that inputs are compatabile with 600 tick wvfms
5689218
@jvmead
removing default values so yaml has to specify
70477b7
@jvmead
narrower segment width to avoid signal in wvfms without padding (may …
04524a0 
…increase spread in baseline but small compared to potential bias from signal)
@jvmead
adding tot and tot upper, need to test
925c6bc
@jvmead
tot and tot_upper included
4bf1e65
@jvmead
running now, need to sanity check
09811b0
@mjkramer @jvmead
Fix NaN baselines
46a57c7
@jvmead
fix for the fix
2460c87
@jvmead
removing derivative and option to not just use local maxima
ccb9929
@jvmead
Merge remote-tracking branch 'upstream/develop' into feature/baseline…
e526cd9 
…_fix_rms_thresholding
@jvmead
Merge branch 'removing_derivative_option' into feature/baseline_fix_r…
3126fd0 
…ms_thresholding
@jvmead
resolving conflicts
53d6bbc
@jvmead
fix the args
10718c4
@jvmead
revert back to cherry picked version
8dde15a
@jvmead
fprompt testing avoiding edge cases or filling with nan
d35d3cb
@jvmead
playing with logic of masking
d75456d
@jvmead
fixes from mathilde for running on run2 data
7c39c1e
@jvmead
Merge branch 'develop' into feature/hits_tot
1b0727c
@jvmead
sanity check run
9d6a964
@jvmead
trying a merge
6428bea
@jvmead
cleanup
64106bb
@jvmead
fixing fprompt: its running but messy - need to check outputs
7c0f427
@jvmead
fixing fprompt method to avoid duplicates and memory issues
5474435
@jvmead
tidy up before new test
c0264b6
@jvmead
adding nanmean version just in case
21ea315
@jvmead
tot and tout thresholds are now parameters
25677cc
@jvmead
making baselinining's number of segments variable depending on the wv…
082e90a 
…fm nsamples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvmead @mjkramer