Skip to content

Additional DVB-I (A177) classification schemes from all published versions#11

Merged
c-alpha merged 8 commits intoDVBProject:masterfrom
paulhiggs:master
Apr 18, 2022
Merged

Additional DVB-I (A177) classification schemes from all published versions#11
c-alpha merged 8 commits intoDVBProject:masterfrom
paulhiggs:master

Conversation

@paulhiggs
Copy link
Copy Markdown
Contributor

No description provided.

@c-alpha
Copy link
Copy Markdown
Contributor

c-alpha commented Apr 15, 2022

Ping?

@paulhiggs
Copy link
Copy Markdown
Contributor Author

Can you merge?

@c-alpha
Copy link
Copy Markdown
Contributor

c-alpha commented Apr 15, 2022

Did you have a look to the review comments?

@paulhiggs
Copy link
Copy Markdown
Contributor Author

Did you have a look to the review comments?

I don't see any for this PR.

@c-alpha
Copy link
Copy Markdown
Contributor

c-alpha commented Apr 16, 2022

Did you have a look to the review comments?

I don't see any for this PR.

Odd; for me they appear just below the list of your seven commits near the top of the conversation tab of this PR's web page. I made two comments on individual lines in metadata.xhtml.

@paulhiggs
Copy link
Copy Markdown
Contributor Author

Odd; for me they appear just below the list of your seven commits near the top of the conversation tab of this PR's web page. I made two comments on individual lines in metadata.xhtml.

I don't see any comments
1

Comment thread metadata.xhtml Outdated
<!-- /wp:paragraph -->

<!-- wp:table {"className":"table table-sm"} -->
<figure class="wp-block-table table table-sm"><table><thead><tr><th>URI</th><th>DVB Standard(s)</th><th>Description</th></tr></thead><tbody><tr><td><a href="/metadata/cs/2019/DVBHowRelatedCS-2019.xml">urn:dvb:metadata:cs:HowRelatedCS:2019</a></td><td>A177</td><td>Initial version</td></tr><tr><td><a href="/metadata/cs/2020/DVBHowRelatedCS-2020.xml">urn:dvb:metadata:cs:HowRelatedCS:2020</a></td><td>A177r1</td><td>Added content finished banner</td></tr><tr><td><a href="/metadata/cs/2021/DVBHowRelatedCS-2021.xml">urn:dvb:metadata:cs:HowRelatedCS:2021</a></td><td>A177r2</td><td>(same as 2020 version)</td></tr></tbody></table></figure>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "(same as 2020 version)" we could perhaps say something more descriptive as for instance "Bump namespace version"?

Comment thread metadata.xhtml
<!-- /wp:paragraph -->

<!-- wp:table {"className":"table table-sm"} -->
<figure class="wp-block-table table table-sm"><table><thead><tr><th>URI</th><th>DVB Standard(s)</th><th>Description</th></tr></thead><tbody><tr><td><a href="/metadata/cs/2019/DVBContentSubjectCS-2019.xml">urn:dvb:metadata:cs:ContentSubject:2019</a></td><td>A177</td><td>Initial version</td></tr></tbody></table></figure>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any ETSI released versions of TS 103 770 that correspond to previous A177 revisions? If yes, shouldn't we list ETSI versions where available?

@c-alpha
Copy link
Copy Markdown
Contributor

c-alpha commented Apr 17, 2022

I figured it; have to explicitly "submit review".

@c-alpha c-alpha merged commit 5e7af0b into DVBProject:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants