Conversation
…yer:dvmhost:codex/fix-v24-r05a05-prready;
…frame being written is greater than the available space then decrementing the m_p25Space, lets properly decrement the space and do an underflow check, because I am pretty confident that is the real problem here;
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cherry pick merges changes from WD6AWP's changes for V.24 call stability branch:
tsawyer:codex/fix-v24-r05a05-prready with some minor changes and proper attribution headers.
Component(s)
Which part(s) of the project does this affect?
Type of change
Related issues
Closed PR (for this one): #116
Build & test notes
For compilation tests I personally performed:
For operational tests this cherry picked branch was executed by WD6AWP and white_lightning on their equipment. white_lightning additionally confirmed via the use of a logic analyzer that this commit fixes missing initial call opcodes being sent via V.24.
Checklist
Notes for maintainers
Before acceptance for this PR, testing should be performed on air and hotspot interfaces to ensure stability with existing functionality.