Skip to content

Implement JobRegistry::submit_bid with proper error handling, event logging, and updated contract test snapshots #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soomtochukwu merged 2 commits into from
Apr 22, 2026
Merged

Implement JobRegistry::submit_bid with proper error handling, event logging, and updated contract test snapshots #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee3f4c
Implement JobRegistry::submit_bid with proper error handling, event l…
OthmanImam Apr 22, 2026
7733deb
Implement JobRegistry::accept_bid with bid validation, event logging,…
OthmanImam Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
493 changes: 453 additions & 40 deletions contracts/job_registry/src/lib.rs
View file
Open in desktop

Large diffs are not rendered by default.

495 changes: 495 additions & 0 deletions contracts/job_registry/test_snapshots/test/test_accept_bid_requires_existing_bid.1.json
View file
Open in desktop

Large diffs are not rendered by default.

801 changes: 801 additions & 0 deletions contracts/job_registry/test_snapshots/test/test_accept_bid_success.1.json
View file
Open in desktop

Large diffs are not rendered by default.

274 changes: 257 additions & 17 deletions contracts/job_registry/test_snapshots/test/test_bid_on_non_open_panics.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,31 @@
}
]
],
[
[
"CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4",
{
"function": {
"contract_fn": {
"contract_address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAITA4",
"function_name": "submit_bid",
"args": [
{
"u64": 1
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
},
{
"bytes": "516d50726f706f73616c"
}
]
}
},
"sub_invocations": []
}
]
],
[
[
"CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
Expand Down Expand Up @@ -111,7 +136,7 @@
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"ledger_key_nonce": {
"nonce": 5541220902715666415
"nonce": 1033654523790656264
}
},
"durability": "temporary"
Expand All @@ -124,6 +149,39 @@
"contract_data": {
"ext": "v0",
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"ledger_key_nonce": {
"nonce": 1033654523790656264
}
},
"durability": "temporary",
"val": "void"
}
},
"ext": "v0"
},
6311999
]
],
[
{
"contract_data": {
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4",
"key": {
"ledger_key_nonce": {
"nonce": 5541220902715666415
}
},
"durability": "temporary"
}
},
[
{
"last_modified_ledger_seq": 0,
"data": {
"contract_data": {
"ext": "v0",
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4",
"key": {
"ledger_key_nonce": {
"nonce": 5541220902715666415
Expand Down Expand Up @@ -174,7 +232,28 @@
},
"durability": "persistent",
"val": {
"vec": []
"vec": [
{
"map": [
{
"key": {
"symbol": "freelancer"
},
"val": {
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
}
},
{
"key": {
"symbol": "proposal_hash"
},
"val": {
"bytes": "516d50726f706f73616c"
}
}
]
}
]
}
}
},
Expand Down Expand Up @@ -410,7 +489,7 @@
"bytes": "0000000000000000000000000000000000000000000000000000000000000004"
},
{
"symbol": "accept_bid"
"symbol": "submit_bid"
}
],
"data": {
Expand All @@ -419,10 +498,66 @@
"u64": 1
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM"
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
"bytes": "516d50726f706f73616c"
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000004",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"string": "job_registry"
},
{
"string": "BidSubmitted"
}
],
"data": {
"map": [
{
"key": {
"symbol": "freelancer"
},
"val": {
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
}
},
{
"key": {
"symbol": "job_id"
},
"val": {
"u64": 1
}
},
{
"key": {
"symbol": "proposal_hash"
},
"val": {
"bytes": "516d50726f706f73616c"
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
}
]
}
Expand All @@ -443,7 +578,7 @@
"symbol": "fn_return"
},
{
"symbol": "accept_bid"
"symbol": "submit_bid"
}
],
"data": "void"
Expand All @@ -467,7 +602,7 @@
"bytes": "0000000000000000000000000000000000000000000000000000000000000004"
},
{
"symbol": "submit_bid"
"symbol": "accept_bid"
}
],
"data": {
Expand All @@ -476,10 +611,10 @@
"u64": 1
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM"
},
{
"bytes": "516d4c617465"
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
}
]
}
Expand All @@ -492,19 +627,99 @@
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000004",
"type_": "diagnostic",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"symbol": "log"
"string": "job_registry"
},
{
"string": "BidAccepted"
}
],
"data": {
"vec": [
"map": [
{
"key": {
"symbol": "client"
},
"val": {
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM"
}
},
{
"key": {
"symbol": "freelancer"
},
"val": {
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFCT4"
}
},
{
"string": "caught panic 'job not open for bids' from contract function 'Symbol(obj#77)'"
"key": {
"symbol": "job_id"
},
"val": {
"u64": 1
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000004",
"type_": "diagnostic",
"body": {
"v0": {
"topics": [
{
"symbol": "fn_return"
},
{
"symbol": "accept_bid"
}
],
"data": "void"
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": null,
"type_": "diagnostic",
"body": {
"v0": {
"topics": [
{
"symbol": "fn_call"
},
{
"bytes": "0000000000000000000000000000000000000000000000000000000000000004"
},
{
"symbol": "submit_bid"
}
],
"data": {
"vec": [
{
"u64": 1
},
Expand All @@ -519,6 +734,31 @@
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000004",
"type_": "diagnostic",
"body": {
"v0": {
"topics": [
{
"symbol": "fn_return"
},
{
"symbol": "submit_bid"
}
],
"data": {
"error": {
"contract": 2
}
}
}
}
},
"failed_call": true
},
{
Expand All @@ -534,12 +774,12 @@
},
{
"error": {
"wasm_vm": "invalid_action"
"contract": 2
}
}
],
"data": {
"string": "caught error from function"
"string": "escalating Ok(ScErrorType::Contract) frame-exit to Err"
}
}
}
Expand All @@ -559,7 +799,7 @@
},
{
"error": {
"wasm_vm": "invalid_action"
"contract": 2
}
}
],
Expand Down Expand Up @@ -604,7 +844,7 @@
},
{
"error": {
"wasm_vm": "invalid_action"
"contract": 2
}
}
],
Expand Down
Loading
Loading