feat(contracts): add EscrowStatus state transition validation and logging#234
Merged
soomtochukwu merged 4 commits intoApr 24, 2026
Merged
Conversation
|
@Obiajulu-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr closes #76
The implementation of
EscrowStatusstate transitions validation acts as a cornerstone for the Lance protocol’s decentralization and reliability strategy. This pull request ensures that theEscrowContractoperates predictably and securely, preventing unauthorized state manipulation and handling error states gracefully.This update introduces strict validation bounds for all milestone-driven escrow workflows, logging critical runtime details to improve observability.
Changes Made
impl EscrowStatuswith avalidate_transitionmethod that enforces a strict state machine (e.g.,Setup -> Funded -> WorkInProgress/Completed -> Disputed -> Resolved).deposit,release_milestone,release_funds,open_dispute,raise_dispute,resolve_dispute, andrefundto use the newvalidate_transitionblock. Added a newEscrowError::InvalidStateTransition(11) error code to handle invalid attempts gracefully.soroban_sdk::log!macro across all state-changing operations in theEscrowContractto emit key data points (job ID, amounts, statuses) to the runtime without polluting persistent on-chain storage.docs/contracts/escrow_state_transitions.mdoutlining the acceptableEscrowStatuspathways and describing the new transition validations.Acceptance Criteria Verified
/docsfolder (escrow_state_transitions.md).EscrowError).Next Steps