Skip to content

feat(escrow): SC-SEC-063 Implement re-entrancy unit tests and compact…#592

Merged
soomtochukwu merged 1 commit into
DXmakers:mainfrom
shogun444:feat/gas-audit-compact-reverts
May 27, 2026
Merged

feat(escrow): SC-SEC-063 Implement re-entrancy unit tests and compact…#592
soomtochukwu merged 1 commit into
DXmakers:mainfrom
shogun444:feat/gas-audit-compact-reverts

Conversation

@shogun444
Copy link
Copy Markdown
Contributor

Summary

Implemented SC-SEC-063 security validation improvements for compact revert handling and re-entrancy protection in the escrow contract.

Closes #417

Changes

  • Added simulated re-entrancy attack coverage using a mock MaliciousToken contract

  • Added test_reentrancy_guard_blocks_reentrant_calls

  • Verified guarded execution aborts correctly on re-entrant behavior

  • Added inline documentation for:

    • compact custom error code mappings
    • packed ContractConfig storage layout
    • reentrancy guard helpers and security flow
  • Preserved existing packed storage and gas-aware contract structure

Validation

  • Ran cargo fmt --all
  • Passed cargo test --lib
  • Verified re-entrant calls abort with expected Soroban host errors
  • Confirmed escrow contract compiles successfully within current WASM structure

@shogun444 shogun444 requested a review from soomtochukwu as a code owner May 27, 2026 15:28
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@shogun444 is attempting to deploy a commit to the mAzI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@shogun444 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@soomtochukwu soomtochukwu merged commit d99f9da into DXmakers:main May 27, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SC-SEC-063] Smart Contract Gas Audit and Storage Compaction - Step 63

2 participants