[BE-W3A-103] Web3 Signature Security and Auditing - Step 103#650
Merged
Conversation
…igations Implement one-time nonce Web3 auth hardening
|
@Johnpii1 is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #457
Description
Added a hardened auth router via createAuthRouter with strict request boundaries using zod, injectable AuthRouteState, and secure session cookie defaults (sessionCookieOptions).
Implemented canonical Stellar address validation (sanitizeStellarAddress) using StrKey decode/encode and checksum checks, bounded signature decoding (extractSignatureBytes), SEP-53-style signature verification (verifyStellarSignature) and challenge construction (buildChallenge).
Enforced atomic one-time nonce consumption by checking auth_challenges.deleteMany(...) before minting sessions and added Redis-backed revocation helpers (isSessionRevoked, revokeSession) with a 1ms lookup budget and a getDefaultRedisClient helper.
Wired session endpoints: /challenge, /verify, /session, and /logout, updated package.json test script, and added comprehensive node:test coverage in backend/tests/auth.test.ts covering address checksums, signature verification, challenge freshness, Redis timing, and replay prevention.
Testing
Ran npm test which executed the new node:test suite and all tests passed (5/5 tests passed).
Attempted npm run build; this currently fails due to existing TypeScript/Prisma issues outside this change (missing PrismaClient export from @prisma/client and several pre-existing implicit any errors in other routes), so build is not green at repository level.