Skip to content

Conversation

@f-raZ0R
Copy link
Contributor

@f-raZ0R f-raZ0R commented Nov 19, 2024

Fixes a lot of recipe unlocks where you unlock the recipe before having unlocked everything used to make it, and vice versa for cases involving pure resources, as pure resources can also be obtained through resonance.
Also seperated out ampoule unlocks so as soon as you can make azurite ones, you unlock azurite ones, without needing to get refined bloodstone just to be able to make azurite ampoules.

Oh, also changed the neat ring recipe to use pure gold instead of regular gold. Because we clearly need to upgrade the recipe every update :3

Copy link
Owner

@DaFuqs DaFuqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff, thanks!
That is a huge bunch of fixes.

Also yes to the neat ring recipe change. It shall be tradition. 🙏

A few things I am not completely sure about:

  • Ampoule unlock change: Now unlocked when collecting any of the required resources for each recipe instead of all 3 of Azurite, Malachite, Bloodstone. I feel the unlock was a nice reward for collecting the whole set and immediately getting all 3 amoules to play around with, instead bit by bit. But having always at least the Azurite one when getting hummingstone is a fair point, too. Opinions?
  • Knowledge Gem unlock change: Was changed from touching liquid crystal to building the Onyx Tier Pedestal. The Onyx Pedestal unlocks quite a bunch of stuff already, so the unlock was there right next to the Enchanter since they go hand in hand and the unlocks do not down in all the start-of-onyx-tier unlocks. Not sure I vibe with that change.

how did i miss this
@DaFuqs DaFuqs merged commit df57b66 into DaFuqs:1.20.1-aria-for-painters Nov 24, 2024
2 checks passed
@unilock
Copy link
Contributor

unilock commented Dec 1, 2024

This PR classloads BotaniaItems before Botania initializes, causing the game to crash during startup :(

@f-raZ0R
Copy link
Contributor Author

f-raZ0R commented Dec 1, 2024

it What.
Oh god it didn't do this in a dev instance

@unilock
Copy link
Contributor

unilock commented Dec 1, 2024

Quoth the Fabric Wiki:

Entrypoints - A note about load order and phases (or a lack thereof)
The order in which mod initializers are called is undefined, and cannot be influenced so that mod A's initializers are called after mod B's initializers, or so that mod C's initializers are called before mod D's initializers.

@f-raZ0R f-raZ0R deleted the unlocks-cleanup branch August 8, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants