Sourcery refactored master branch#1
Open
sourcery-ai[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| for movie_title in movies: | ||
| movies_instances.append(Movie(movie_title)) | ||
|
|
||
| movies_instances.extend(Movie(movie_title) for movie_title in movies) |
Author
There was a problem hiding this comment.
Function get_movies refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| for movie_title in movies: | ||
| movies_instances.append(Movie(movie_title)) | ||
|
|
||
| movies_instances.extend(Movie(movie_title) for movie_title in movies) |
Author
There was a problem hiding this comment.
Function get_movies refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| for movie_title in movies: | ||
| movies_instances.append(Movie(movie_title)) | ||
|
|
||
| movies_instances.extend(Movie(movie_title) for movie_title in movies) |
Author
There was a problem hiding this comment.
Function get_movies refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| for movie_title in movies: | ||
| movies_instances.append(Movie(movie_title)) | ||
|
|
||
| movies_instances.extend(Movie(movie_title) for movie_title in movies) |
Author
There was a problem hiding this comment.
Function get_movies refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| movie = Movie(title=movie_title) | ||
| result = movie.add_to_movies() | ||
| if result: | ||
| if result := movie.add_to_movies(): |
Author
There was a problem hiding this comment.
Function App.add_movie refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-0
to
+4
| a = "J'ai une classe de " + str(30) + " élèves" | ||
| b = str(10) + " + " + "5" + " est égal à " + str(15) | ||
| a = f"J'ai une classe de {30} élèves" | ||
| b = f"{10} + 5 est égal à {15}" | ||
| c = 10 + int("5") | ||
| d = "L'addition de 10 + 5 est égal à " + str(10 + 5) No newline at end of file | ||
| d = f"L'addition de 10 + 5 est égal à {str(10 + 5)}" No newline at end of file |
Author
There was a problem hiding this comment.
Lines 1-4 refactored with the following changes:
- Use f-string instead of string concatenation [×7] (
use-fstring-for-concatenation) - Remove unnecessary calls to
str()from formatted values in f-strings [×3] (remove-str-from-fstring)
Comment on lines
-2
to
+14
| nombres_pairs = [] | ||
| for i in nombres: | ||
| if i % 2 == 0: | ||
| nombres_pairs.append(i) | ||
|
|
||
| nombres_pairs = [i for i in nombres if i % 2 == 0] | ||
| print(nombres_pairs) | ||
|
|
||
| # ---------------------------------------------------- # | ||
|
|
||
| nombres = range(-10, 10) | ||
| nombres_positifs = [] | ||
| for i in nombres: | ||
| if i >= 0: | ||
| nombres_positifs.append(i) | ||
|
|
||
| nombres_positifs = [i for i in nombres if i >= 0] | ||
| print(nombres_positifs) | ||
|
|
||
| # ---------------------------------------------------- # | ||
|
|
||
| nombres = range(5) | ||
| nombres_doubles = [] | ||
| for i in nombres: | ||
| nombres_doubles.append(i * 2) | ||
|
|
||
| nombres_doubles = [i * 2 for i in nombres] |
Author
There was a problem hiding this comment.
Lines 2-25 refactored with the following changes:
- Convert for loop into list comprehension [×3] (
list-comprehension)
| return -1 | ||
| else: | ||
| return User.DB.insert(self.__dict__) | ||
| return -1 if self.exists() else User.DB.insert(self.__dict__) |
Author
There was a problem hiding this comment.
Function User.save refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| return -1 | ||
| else: | ||
| return User.DB.insert(self.__dict__) | ||
| return -1 if self.exists() else User.DB.insert(self.__dict__) |
Author
There was a problem hiding this comment.
Function User.save refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| return -1 | ||
| else: | ||
| return User.DB.insert(self.__dict__) | ||
| return -1 if self.exists() else User.DB.insert(self.__dict__) |
Author
There was a problem hiding this comment.
Function User.save refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!