Forensics Overhaul #813
Merged
Forensics Overhaul #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#79154) ## About The Pull Request This adds a global list to precalculate lists that need to be handled special by vv instead of manually updating such a list. @LemonInTheDark brought up a potential issue with handling all lists in the way special lists are handled, that modifying a list in vv can in some cases result in the wrong list being opened for editing. This makes only special lists have the issue instead of blindly accessing all lists the same way.
I forgot name could be a number for list indexes, so this switches to using `in` instead. Also improves the error message a little bit so reported issues can at least say *something* about the value throwing an error. fixes #79280 fixes #79264
Kapu1178
force-pushed
the
forensicsrefactor
branch
from
a5c4095 to
e4dad90
Compare
JohnFulpWillard
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Feb 22, 2024
Footprint sprites no longer have to be the same "shoe" sprite, they are now based on what shoes you're wearing and what legs you have They are also renamed, i.e., if they're paws, they're called pawprints and not footprints Shoes have priority over legs I have changed monkey legs to have paw footprints Code is from DaedalusDock/daedalusdock#813, except I renamed some defines and vars and tweaked it a bit A future use for this is, adding human FOOT (not shoe) print sprites, so people without shoes would make actual FEET print sprites I didn't do this cuz I can't sprite, but it's possible now Also didn't do this cuz I'd like to replace the existing footprints with the more grimy Baystation footprints, they look much better, but that's for a separate PR Any lizard superfans could also sprite something for lizards, the possibilities are endless
NaakaKo
pushed a commit
to Bird-Lounge/Skyraptor-SS13
that referenced
this pull request
Feb 22, 2024
Footprint sprites no longer have to be the same "shoe" sprite, they are now based on what shoes you're wearing and what legs you have They are also renamed, i.e., if they're paws, they're called pawprints and not footprints Shoes have priority over legs I have changed monkey legs to have paw footprints Code is from DaedalusDock/daedalusdock#813, except I renamed some defines and vars and tweaked it a bit A future use for this is, adding human FOOT (not shoe) print sprites, so people without shoes would make actual FEET print sprites I didn't do this cuz I can't sprite, but it's possible now Also didn't do this cuz I'd like to replace the existing footprints with the more grimy Baystation footprints, they look much better, but that's for a separate PR Any lizard superfans could also sprite something for lizards, the possibilities are endless
…into forensicsrefactor
KnigTheThrasher
added a commit
to KnigTheThrasher/Monkestation2.0
that referenced
this pull request
Feb 27, 2024
Footprint sprites no longer have to be the same "shoe" sprite, they are now based on what shoes you're wearing and what legs you have They are also renamed, i.e., if they're paws, they're called pawprints and not footprints Shoes have priority over legs I have changed monkey legs to have paw footprints Code is from DaedalusDock/daedalusdock#813, except I renamed some defines and vars and tweaked it a bit A future use for this is, adding human FOOT (not shoe) print sprites, so people without shoes would make actual FEET print sprites I didn't do this cuz I can't sprite, but it's possible now Also didn't do this cuz I'd like to replace the existing footprints with the more grimy Baystation footprints, they look much better, but that's for a separate PR Any lizard superfans could also sprite something for lizards, the possibilities are endless
DaedalusDock-Services
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why It's Good For The Game
A remake of alot of the Aurora detective mechanics that were ported to bay so many years ago. And alot of my own stuff.
Optimized a couple very expensive procs w/ Lohikar, Ter, and Lummox's help.
Changelog
🆑 Kapu1178, Fikou, Tau-Ceti, Baystation12, Aurorastation, with help from Lohikar, Ter, and Lummox. Hitsplatter sprites modified by 13spacemen.
fix: Fingerprints are now applied in more situations. Did you know that punching someone didn't apply fingerprints?
fix: Fingerprints are now applied more realistically, attempting to add to clothing first where applicable.
fix: Blood is now left on items you touch if your hands or gloves are bloody.
fix: Tracking blood on feet/shoes works correctly.
refactor: Rewrote the forensics component into a datum.
add: Two new forensic information classes, Trace DNA and Gunshot Residue. Trace DNA is left by doing things such as biting, smoking a cigarette, or drinking. Gunshot Residue is left by ballistic firearms.
add: Fingerprints are now only partially left, sometimes requiring multiple touches to give full clarity to the print.
add: Blood can now be colors other than red.
add: There is more blood.
add: Detective now gets a filing cabinet that contains a paper copy of each crew member's record when they joined.
qol: Cleaned up evidence bag behavior to be in line with other storage objects.
add: Added sample kits for different forensic information. Fingerprint cards for fingerprints, swabs for trace DNA or blood DNA, a fiber kit for material fibers, and finger print powder for finding fingerprints on objects.
add: Scene cards to mark crime scenes.
add: Detective now gets an Electron Microscope, to analyze fingerprints, fibers, and residue.
refactor: Rewrote the Forensic Scanner into the DNA Scanner. It is now only used for trace DNA and blood DNA samples.
/:cl: