Empty list exceptions throwing empty lists #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneMander
requested changes
Mar 12, 2025
Collaborator
ShaneMander
left a comment
ShaneMander
left a comment
There was a problem hiding this comment.
Nice that we are reviewing our http responses. Overall, I think a few of the catch blocks can be simplified to not having the if (e.entity == EntityType....). Additionally, in some areas we seem to be adding catch-blocks for exceptions that aren't being thrown (although, it's possible I missed where exactly some are being thrown)
src/main/java/com/danielagapov/spawn/Controllers/ChatMessageController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/danielagapov/spawn/Controllers/ChatMessageController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/danielagapov/spawn/Controllers/EventController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/danielagapov/spawn/Controllers/LocationController.java
Outdated
Show resolved
Hide resolved
OnionFastener
dismissed
ShaneMander’s stale review
The merge-base changed after approval.
Daggerpov
previously approved these changes
Mar 31, 2025
Daggerpov
approved these changes
Mar 31, 2025
Owner
|
Thanks for starting this off, @OnionFastener ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #179