Skip to content

fix: default project_root to cwd when repo_url is provided #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhvishalkr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: default project_root to cwd when repo_url is provided #689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b2fecf
fix: default project_root to cwd when repo_url is provided
singhvishalkr Apr 21, 2026
fb426d2
fix: chain ValueError and log cwd fallback
singhvishalkr Apr 21, 2026
604dcbd
fix(filesystem): clarify ValueError when repo_url implies optional pr…
singhvishalkr May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions dagshub/streaming/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,21 @@ def __init__(
if not project_root:
try:
self.project_root = get_project_root(Path(os.path.abspath(".")))
except ValueError:
raise ValueError(
"Could not find a git repo. Either run the function inside of a git repo, "
"specify `project_root` with the path to a cloned DagsHub repository, "
"or specify `repo_url` (url of repo on DagsHub) and "
"`project_root` (path to the folder where to mount the filesystem) arguments"
)
except ValueError as err:
if repo_url:
self.project_root = Path(os.path.abspath("."))
log_message(
f"No git repo detected; mounting DagsHub filesystem for {repo_url} at "
f"current working directory: {self.project_root}",
logger,
)
else:
raise ValueError(
"Could not find a git repo. Either run the function inside of a git repo, "
"specify `project_root` with the path to a cloned DagsHub repository, "
"or specify `repo_url` (url of repo on DagsHub); "
"optionally provide `project_root` (defaults to current working directory)"
) from err

else:
self.project_root = Path(os.path.abspath(project_root))
Expand Down