Migrate Change Password View from XML to Compose #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Create password change screen using updated SetPasswordView
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (4)
- presentation/src/main/res/layout/fragment_setting_change_password_current.xml: Language not supported
- presentation/src/main/res/layout/fragment_setting_change_password_new.xml: Language not supported
- presentation/src/main/res/navigation/nav_graph.xml: Language not supported
- presentation/src/main/res/values/strings.xml: Language not supported
Comments suppressed due to low confidence (2)
presentation/src/main/java/daily/dayo/presentation/viewmodel/AccountViewModel.kt:405
- [nitpick] The variable name 'ApiResponse' uses upper camel case, which is inconsistent with Kotlin's lowerCamelCase naming convention. Consider renaming it to 'apiResponse'.
requestCheckCurrentPasswordUseCase(password = inputPassword).let { ApiResponse ->
presentation/src/main/java/daily/dayo/presentation/screen/settings/ChangePasswordScreen.kt:211
- Displaying the loading indicator for both LOADING and SUCCESS states may confuse users; consider showing it only for the LOADING state.
Loading(isVisible = changePasswordStatus == Status.LOADING || changePasswordStatus == Status.SUCCESS,)
yuni-ju
approved these changes
Apr 9, 2025
Member
yuni-ju
left a comment
yuni-ju
left a comment
There was a problem hiding this comment.
좋습니다! 👍
나중에 소셜 로그인은 비밀번호 변경이 안 된다는 것에 대한 별도의 알림이 있으면 더 좋을 것 같네용
# Conflicts: # presentation/src/main/java/daily/dayo/presentation/screen/main/MainNavigator.kt # presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsNavigation.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt # presentation/src/main/res/navigation/nav_graph.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
참고