npm install test 워크플로우 구현 #656

RiaOh · 2025-12-07T03:30:23Z

변경 사항

release > main PR이 생성되었을때 daleui npm 패키지의 install 가능 여부 테스트

목적

실제 우리 daleui 패키지를 publish하기 전, 정상적으로 잘 설치되고 동작되는지 검증을 위하여

리뷰어에게

이 작업이 익숙치 않아서 작업 방향성이 맞는지(?) 봐주시면 감사하겠습니다 :)

PR 작성자 체크 리스트

UI Review를 요청하고 검토를 받았나요?
UI Tests를 진행했나요?

.github/workflows/npm-install-tests.yml

DaleSeo · 2025-12-12T03:23:07Z

@RiaOh 님, PR을 티켓과 연결 부탁드리겠습니다. 보드에 안 나와서 제가 계속 놓치고 있었네요.

.github/workflows/npm-install-tests.yml

DaleSeo · 2025-12-20T02:51:55Z

.github/workflows/npm-install-tests.yml

@@ -0,0 +1,125 @@
+name: NPM Install Test - daleui


Suggested change

name: NPM Install Test - daleui

name: NPM Install Test

@DaleSeo 네, 065a197 해당 커밋에서 수정하였습니다! :)

codecov · 2025-12-28T11:22:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

DaleSeo

피드백 반영해주셔서 감사합니다.

.github/workflows/integration.yml

codecov · 2026-01-03T22:01:32Z

Bundle Report

Bundle size has no change ✅

RiaOh · 2026-01-04T06:53:16Z

@DaleSeo @hyoseong1994
배포 프로세스 변경된 방향으로 수정하여 commit하였습니다.
approve해주셨지만 변경된 부분이 있어 다시 봐주시면 감사하겠습니다!

Discord: https://discord.com/channels/775115965964222492/1456457228784767079

아, 추가로 index.ts파일에 Box컴포넌트가 없던데 추가되어야하는거죠?
추가해야한다면 제가 같이 작업하고 commit하려고 합니다!

DaleSeo · 2026-01-04T19:52:23Z

.github/workflows/integration.yml

+      # ========================================
+      # 테스트 프로젝트 생성 + daleui 설치
+      # ========================================


이런 코멘트는 득보다 실이 많지 않을까요? 나중에 다른 분이 작업 내용을 수정할 때 함께 업데이트하는 것을 까먹기 쉽거든요. name 필드에서 작업 내용을 영어로 잘 나타내고 있기 때문에 불필요한 코멘트라고 생각합니다.

@DaleSeo 아하, 네엡! 알겠습니다. 코멘트들은 제거하겠습니다!

DaleSeo · 2026-01-04T19:54:36Z

.github/workflows/integration.yml

+          - name: "Create React App (React 18)"
+            project: cra


@RiaOh 님, 우리 CRA 테스트는 그냥 하지 마시죠. CRA는 2022년 4월 이후로 업데이트가 전혀 없으며, React 공식 문서에서도 사라지면서 사실 상 폐기(deprecated) 수순을 밟고 있거든요. 워크플로우 로그를 보시면 high 단계 보안 취약점이 6개나 있는 걸 보면, 이 프로젝트 사실 상 제대로 유지보수가 되고 있다고 보기 어려울 것 같습니다. 2026년에는 React 생태계가 CRA에서 완전히 벗어나는 동참하는 차원에서 우리도 쓰지 말고, 사용자들도 쓰지 말라고 권장했으면 좋겠습니다.

CRA 제거하면 matrix 안 써도 되서 워크플로우도 간단해지고, 1분 내에 실행이 끝날 수 있을 것입니다. 워크플로우가 이제 PR이 병합될 때가 아니라 PR에 변경이 있을 때 마다 실행이 되기 때문에 빠른 피드백을 줄 수 있어서 개발자 경험에도 도움이 될 거에요.

DaleSeo · 2026-01-04T19:59:30Z

리베이스 하시면 본 PR과 무방한 2개의 UI 변경이 사라질 것입니다.

hyoseong1994 · 2026-01-04T23:39:22Z

아, 추가로 index.ts파일에 Box컴포넌트가 없던데 추가되어야하는거죠?
추가해야한다면 제가 같이 작업하고 commit하려고 합니다!

맞아요 Box는 최근에 업데이트된거라서 index에 추가안된거같네요

hyoseong1994

CRA 제거하여 vite만 테스트하는 부분에 대해서 동의합니다.
이미 리뷰가 달려있어서 해당부분만 수정해주시면 좋을거같아요!

.github/workflows/integration.yml

+    runs-on: ubuntu-latest
+    name: "Vite + React"
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+        with:
+          bun-version: latest
+
+      - name: Install dependencies & Build
+        run: |
+          bun install
+          bun run build:lib
+
+      - name: Create test project & install daleui
+        run: |
+          mkdir /tmp/test-project && cd /tmp/test-project
+          bun create vite@5 . --template react-ts
+          bun install
+          bun add "$GITHUB_WORKSPACE"
+
+      - name: Add daleui smoke test
+        run: |
+          cd /tmp/test-project
+          mkdir -p src/smoke
+          cat > src/smoke/DaleTest.tsx << 'EOF'
+          import { Button } from 'daleui';
+
+          export default function DaleTest() {
+            return (
+              <div data-testid="daleui-smoke">
+                <Button>daleui 성공적으로 로드됨!</Button>
+              </div>
+            );
+          }
+          EOF
+
+      - name: Run production build
+        run: |
+          cd /tmp/test-project
+          bun run build


Bumps [eslint-plugin-testing-library](https://github.com/testing-library/eslint-plugin-testing-library) from 7.13.5 to 7.13.6. - [Release notes](https://github.com/testing-library/eslint-plugin-testing-library/releases) - [Changelog](https://github.com/testing-library/eslint-plugin-testing-library/blob/main/release.config.js) - [Commits](testing-library/eslint-plugin-testing-library@v7.13.5...v7.13.6) --- updated-dependencies: - dependency-name: eslint-plugin-testing-library dependency-version: 7.13.6 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the storybook group with 6 updates: | Package | From | To | | --- | --- | --- | | [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y) | `10.1.10` | `10.1.11` | | [@storybook/addon-designs](https://github.com/storybookjs/addon-designs) | `11.1.0` | `11.1.1` | | [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs) | `10.1.10` | `10.1.11` | | [@storybook/addon-themes](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/themes) | `10.1.10` | `10.1.11` | | [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite) | `10.1.10` | `10.1.11` | | [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) | `10.1.10` | `10.1.11` | Updates `@storybook/addon-a11y` from 10.1.10 to 10.1.11 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/addons/a11y) Updates `@storybook/addon-designs` from 11.1.0 to 11.1.1 - [Release notes](https://github.com/storybookjs/addon-designs/releases) - [Changelog](https://github.com/storybookjs/addon-designs/blob/master/CHANGELOG.v1-6.md) - [Commits](storybookjs/addon-designs@v11.1.0...v11.1.1) Updates `@storybook/addon-docs` from 10.1.10 to 10.1.11 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/addons/docs) Updates `@storybook/addon-themes` from 10.1.10 to 10.1.11 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/addons/themes) Updates `@storybook/react-vite` from 10.1.10 to 10.1.11 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/frameworks/react-vite) Updates `storybook` from 10.1.10 to 10.1.11 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/core) --- updated-dependencies: - dependency-name: "@storybook/addon-a11y" dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/addon-designs" dependency-version: 11.1.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/addon-docs" dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/addon-themes" dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/react-vite" dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: storybook dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [eslint-plugin-storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/eslint-plugin) from 10.1.9 to 10.1.11. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.1.11/code/lib/eslint-plugin) --- updated-dependencies: - dependency-name: eslint-plugin-storybook dependency-version: 10.1.11 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…overage-v8

RiaOh requested a review from a team as a code owner December 7, 2025 03:30

github-actions bot assigned RiaOh Dec 7, 2025

RiaOh deployed to chromatic December 7, 2025 03:30 — with GitHub Actions View deployment

github-advanced-security bot found potential problems Dec 7, 2025

View reviewed changes

.github/workflows/npm-install-tests.yml Fixed Show fixed Hide fixed

RiaOh deployed to chromatic December 7, 2025 12:12 — with GitHub Actions View deployment

hyoseong1994 reviewed Dec 10, 2025

View reviewed changes

.github/workflows/npm-install-tests.yml Outdated Show resolved Hide resolved

.github/workflows/npm-install-tests.yml Fixed Show fixed Hide fixed

.github/workflows/npm-install-tests.yml Outdated Show resolved Hide resolved

DaleSeo reviewed Dec 12, 2025

View reviewed changes

RiaOh linked an issue Dec 13, 2025 that may be closed by this pull request

npm install test 워크플로우 구현 #611

Closed

RiaOh deployed to chromatic December 13, 2025 07:05 — with GitHub Actions View deployment

hyoseong1994 approved these changes Dec 18, 2025

View reviewed changes

hyoseong1994 mentioned this pull request Dec 18, 2025

릴리즈 발행시 동작하는 배포 워크플로우 생성 #654

Merged

2 tasks

DaleSeo reviewed Dec 20, 2025

View reviewed changes

RiaOh deployed to chromatic December 28, 2025 11:22 — with GitHub Actions View deployment

DaleSeo approved these changes Dec 28, 2025

View reviewed changes

RiaOh deployed to chromatic January 3, 2026 07:35 — with GitHub Actions View deployment

github-advanced-security bot found potential problems Jan 3, 2026

View reviewed changes

.github/workflows/integration.yml Fixed Show fixed Hide fixed

RiaOh deployed to chromatic January 3, 2026 07:43 — with GitHub Actions View deployment

RiaOh added 9 commits January 3, 2026 21:25

feat: add npm-install-test workflow

c0d10f8

chore: add permissions

5225a9c

delete: delete permissions

d10e660

chore: change node version 20 to lts

bbae4d8

chore: change actions/checkout version 4 to 6

cde6704

chore: change workflow name

ccab92b

chore: change npm to bun & remove Next.js step

886ad09

feat: add install-tests in integration workflow

b3735b2

fix: change bunx to bun

1841324

RiaOh force-pushed the 611-npm-install-test-workflow branch from 91dfc80 to 1841324 Compare January 3, 2026 12:26

RiaOh deployed to chromatic January 3, 2026 12:26 — with GitHub Actions View deployment

fix: remove import React

a651e05

RiaOh deployed to chromatic January 3, 2026 15:26 — with GitHub Actions View deployment

RiaOh requested review from DaleSeo and hyoseong1994 January 3, 2026 15:30

chore: change bunx to bun to make same with vite

bfe094d

RiaOh deployed to chromatic January 4, 2026 06:34 — with GitHub Actions View deployment

RiaOh requested a review from sounmind January 4, 2026 06:48

DaleSeo reviewed Jan 4, 2026

View reviewed changes

hyoseong1994 approved these changes Jan 4, 2026

View reviewed changes

RiaOh added 3 commits January 6, 2026 23:31

chore: remove CRA case

3c69ba6

chore: add Box component in index.ts

d42c88c

chore: remove comment

2966741

RiaOh deployed to chromatic January 6, 2026 14:32 — with GitHub Actions View deployment

github-advanced-security bot found potential problems Jan 6, 2026

View reviewed changes

DaleSeo and others added 6 commits January 8, 2026 00:07

refactor: set auth token to environment variable

3588eb6

ci: stop using release branches for tagging workflow

02aa1e6

chroe: add dependabot group for eslint-plugin-storybook and @vitest/c…

51ad6d4

…overage-v8

RiaOh deployed to chromatic January 7, 2026 15:08 — with GitHub Actions View deployment

RiaOh added this pull request to the merge queue Jan 7, 2026

Merged via the queue into main with commit 8f8a875 Jan 7, 2026
11 of 12 checks passed

RiaOh deleted the 611-npm-install-test-workflow branch January 7, 2026 15:17

github-actions bot mentioned this pull request Jan 8, 2026

release: v0.0.5 #731

Closed

Uh oh!

npm install test 워크플로우 구현 #656

npm install test 워크플로우 구현 #656

Uh oh!

Conversation

RiaOh commented Dec 7, 2025

변경 사항

목적

리뷰어에게

PR 작성자 체크 리스트

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaleSeo commented Dec 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaleSeo Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

RiaOh Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 28, 2025

Codecov Report

Uh oh!

DaleSeo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jan 3, 2026

Bundle Report

Uh oh!

RiaOh commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaleSeo Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

RiaOh Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

DaleSeo Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

DaleSeo commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyoseong1994 commented Jan 4, 2026

Uh oh!

hyoseong1994 left a comment

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RiaOh commented Jan 4, 2026 •

edited

Loading

DaleSeo commented Jan 4, 2026 •

edited

Loading