Made selected theme load much sooner, cached themes locally#2
Merged
DamiDoop merged 2 commits intoDamiDoop:mainfrom Jan 31, 2025
Merged
Made selected theme load much sooner, cached themes locally#2DamiDoop merged 2 commits intoDamiDoop:mainfrom
DamiDoop merged 2 commits intoDamiDoop:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to setting a listener on
DOMContentLoadedrather thanload, which causes the JS to run much sooner and prevent the page from having to fully load the default theme before loading the correct one.DOMContentLoadedtriggers when the actual HTML is done loading and is fully parsed, whereasloadtriggers when 100% of the page content (including heavy stuff like images) has finished loading.I also added the CSS to
/assets/css/themeso that they load faster (it was also essential to being able to test things reasonably quickly on school WiFi).