Skip to content

Fix translations if zero entities have been found#605

Merged
DamienHarper merged 2 commits intoDamienHarper:masterfrom
dmitryuk:fix/zero-view-entities
Mar 10, 2026
Merged

Fix translations if zero entities have been found#605
DamienHarper merged 2 commits intoDamienHarper:masterfrom
dmitryuk:fix/zero-view-entities

Conversation

@dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Mar 10, 2026

  • Visit auditor viewer
  • Select some entity
  • Use filter to get 0 entities found

Expected result - no entities page
Fact results - 500 page

An exception has been thrown during the rendering of a template ("Unable to choose a translation for "{1} %formatted_count% событие|[2,4] %formatted_count% события|]4,Inf[ %formatted_count% событий" with locale "ru" for value "0". Double check that this translation has the correct plural options (e.g. "There is one apple|There are %count% apples").") in @DHAuditor/Audit/entity_stream.html.twig at line 25.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.35%. Comparing base (6cb6c01) to head (ce249f1).
⚠️ Report is 107 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   93.11%   85.35%   -7.76%     
==========================================
  Files          15       15              
  Lines         334      642     +308     
==========================================
+ Hits          311      548     +237     
- Misses         23       94      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DamienHarper DamienHarper merged commit 3d94ecd into DamienHarper:master Mar 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants