Draft
Conversation
MSRV was bumped to 1.85 making these clippy allowances unnecessary. The lint no longer fires. Resolves payjoin#794
Pull Request Test Coverage Report for Build 22572331810Details
💛 - Coveralls |
a6e8bc8 to
5e1492a
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[allow(clippy::incompatible_msrv)]attributes frompayjoin-clithat are no longer neededCloses payjoin#794
Test plan
nix fmt -- --cipassescargo clippy --all-targets --keep-going --all-features -- -D warningscleancodespellcleanDisclosure: co-authored by Claude