feat(click casting): optionally target the unit you click-cast on#116
Closed
Krathe82 wants to merge 1 commit into
Closed
feat(click casting): optionally target the unit you click-cast on#116Krathe82 wants to merge 1 commit into
Krathe82 wants to merge 1 commit into
Conversation
Adds a "target on cast" behaviour so click-casting a spell on a frame can also set that unit as your target. - Global toggle "Target unit when click-casting" in the Click Casting profiles panel (off by default). - Per-binding override (Advanced -> Macro Options) that wins over the global; nil inherits the global, so existing binds follow the toggle. - Implemented by appending "/target [@mouseOver,exists] mouseover" to the generated cast macro. The mouseover gate means a frame click targets that unit while a target-fallback cast leaves your current target alone. Works in combat (secure macro). Covers the single and combined (friendly+hostile) macro paths; the combined path targets if any contributing binding opts in. - Applies to spell/item casts only; custom macros and the target/focus/ menu/assist special actions are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "target on cast" behaviour so click-casting a spell on a frame can also set that unit as your target (lab features #410, #15).
/target [@mouseover,exists] mouseoverto the generated cast macro. The mouseover gate means a frame click targets that unit, while a target-fallback cast (nothing hovered) leaves your current target alone. Works in combat (secure macro).Test plan