(Dispel Overlay) Fix overlay leaking onto live frames when editing settings in test mode#66
Merged
DanderBot merged 1 commit intoMay 11, 2026
Conversation
…ttings in test mode
Owner
|
Thanks for the PR! Merged into main and will ship in the next alpha build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateAllDispelOverlaysiterates live party/raid frames viaIterateAllFrameswith no test-mode checkUpdateDispelOverlayruns the test-mode branch on live secure frames and callsShowOverlayWithRGBwith test data on those hidden live frames/reloadclears itUpdateAllDispelOverlaysnow detects active test mode and routes to the test frame arrays directly, skipping live frames entirelytestMode = falseis set before the cleanup timer fires), the live-frame cleanup pass runs correctly via the normalIterateAllFramespathTest plan
/df test)/reloadrequired