Skip to content

feat: add Default button to DF colour picker#95

Merged
DanderBot merged 1 commit into
DanderBot:mainfrom
Krathe82:feat/color-picker-default-button
May 19, 2026
Merged

feat: add Default button to DF colour picker#95
DanderBot merged 1 commit into
DanderBot:mainfrom
Krathe82:feat/color-picker-default-button

Conversation

@Krathe82
Copy link
Copy Markdown
Contributor

@Krathe82 Krathe82 commented May 18, 2026

Summary

  • Adds a Default button to the DF colour picker, stacked below the Save button in the tab row. Clicking it resets the colour to the setting's configured default value with live preview.
  • Populates ElvUI's ColorPPDefault button with the DF default when any DF setting's colour picker is opened, enabling it on the native Blizzard picker.
  • Resource bar (power) colour pickers now correctly resolve defaults via WoW's PowerBarColor table as a fallback when no entry exists in PartyDefaults/RaidDefaults.
  • Fixes a noisy "Color picker hook already active" chat message that fired incorrectly when toggling the global color picker override checkbox.

Test plan

  • Open any DF colour setting — Default button appears below Save in the picker tab row and resets to the setting default with live preview
  • Open a resource bar power colour — Default button appears and resets to the WoW default for that power type
  • With ElvUI installed and DF override off, open a DF colour setting — ElvUI's Default button on the native picker is enabled and pastes the correct DF default
  • Toggle "Use DF Color Picker for All Addons" on and off — no spurious chat messages

Adds a Default button stacked below the Save button in the DF colour
picker tab row. Clicking it resets the colour to the setting's configured
default (from PartyDefaults/RaidDefaults) with live preview via the
onChange callback.

Also populates ElvUI's ColorPPDefault button with the DF default when
opening any DF setting's colour picker, so it enables and pastes the
correct value on the native Blizzard picker.

Resource bar (power) colour pickers now also resolve their default via
WoW's PowerBarColor table as a fallback when no entry exists in
PartyDefaults/RaidDefaults.

Fixes noisy "Color picker hook already active" chat message when
toggling the global color picker override setting.
DanderBot added a commit that referenced this pull request May 19, 2026
@DanderBot DanderBot merged commit 85d23f2 into DanderBot:main May 19, 2026
@Krathe82 Krathe82 deleted the feat/color-picker-default-button branch June 4, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants