[arch/memdomain] fix: resolve ther bug of CI TEST#21
Merged
Mikemy666 merged 1 commit intoDangoSys:mainfrom Dec 19, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where DMA writes were incorrectly configured to accumulate data instead of overwriting it. The fix ensures that DMA operations always perform direct overwrites, while execution unit operations retain their ability to accumulate when needed.
Key changes:
- Fixed the
is_accflag assignment for DMA writes to always befalse.Binstead of usingmain_isacc_sel - Removed obsolete commented-out code for accumulator read/write interfaces
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DMA overwrite the acc part instead of accumulate on it