Merged
Conversation
…for-item-count-by-creator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
unknownbecause entitlements only contained creator IDs and not display names, so clients could not show human-friendly creator names.Description
creatorLookupparameter tosummarizeCreatorsinsrc/utils/inventoryCreators.jsso resolved creator identifiers can be mapped to display names.getCreatorsand build an ID→displayName lookup insrc/routes/inventory.routes.jsandsrc/routes/purchase.routes.js, then pass that lookup intosummarizeCreators.src/utils/swagger.jsand the README to indicate creators are grouped by display name and add an exampleGET /inventory/creatorscurl line.test/inventoryCreators.test.jsthat verifies mapping of creator IDs to display names.Testing
npm testand all tests passed: 3 tests, 0 failures.Codex Task