-
Notifications
You must be signed in to change notification settings - Fork 0
get methods #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get methods #2
Conversation
with this all the github request are easier to control and don't have to repeat all the parameters
* usign buffer * usign buffer * using svn url * without expect * ignore download repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty awesome, all tests look pretty good, just a couple of comments and later if you want you can include a linter so all the code has the same format and to validate general things
test/GithubApi.Respositories.test.js
Outdated
| }); | ||
| }); | ||
| }); | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this line
test/MyfirstApiConsume.test.js
Outdated
| }); | ||
|
|
||
|
|
||
| }); No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOL
No description provided.