Skip to content

CAS-141: Add WinningVote Bonus#107

Merged
jbluks merged 25 commits intomainfrom
CAS-141
Jul 12, 2022
Merged

CAS-141: Add WinningVote Bonus#107
jbluks merged 25 commits intomainfrom
CAS-141

Conversation

@jbluks
Copy link
Copy Markdown
Collaborator

@jbluks jbluks commented Jul 7, 2022

Ticket: CAS-141

Description

  • Winning Vote calculated when proposal results are requested and the proposal is in a closed state.
  • Once winning votes are calculated, they will be skipped in the future if entries already exist for that proposal, keeping the request for proposal results from doing unnecessary work
  • Updates UserAchievements query to correctly get each of the achievements for the user. Previous version was not properly joining the pivot table and would break when not all achievements were present in table.

Jonathan and others added 21 commits June 23, 2022 12:08
@jbluks jbluks force-pushed the CAS-141 branch 4 times, most recently from d08b7bb to 5619ae8 Compare July 8, 2022 01:57
@0xmovses
Copy link
Copy Markdown
Contributor

0xmovses commented Jul 8, 2022

There are duplicates of migration 000020 so I'm not able to run the migrations and tests at the mo.

Copy link
Copy Markdown
Contributor

@jacksonConrad jacksonConrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, otherwise looks great!

Comment thread backend/main/server/app.go Outdated
@jbluks jbluks merged commit 2fe40a7 into main Jul 12, 2022
@jbluks jbluks deleted the CAS-141 branch July 12, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants