cas-107 Delay proposal start by 1 hour in production env (UI ONLY)#138
cas-107 Delay proposal start by 1 hour in production env (UI ONLY)#138germanurrus merged 10 commits intomainfrom
Conversation
| if (cutOffDate) { | ||
| const nowDate = new Date(); | ||
| const nowDate = | ||
| process.env.NODE_ENV === 'production' |
There was a problem hiding this comment.
Need to introduce a new environment variable like APP_ENV because staging uses NODE_ENV=production
https://github.com/DapperCollectives/CAST/blob/main/frontend/Dockerfile.stage#L11
There was a problem hiding this comment.
Talked with Fer, and now using APP_ENV, which is also used in the backend.
germanurrus
left a comment
germanurrus
left a comment
There was a problem hiding this comment.
Waiting for confirmation for APP env
| process.env.APP_ENV === 'PRODUCTION' | ||
| ? new Date(Date.now() + 60 * 60 * 1000) // delay by an hour in prod env | ||
| : new Date(); | ||
| nowDate.setSeconds(0); |
There was a problem hiding this comment.
@fersan1985 I've checked on this file
Lines 19 to 20 in ca706f8
There was a problem hiding this comment.
added APP_ENV on Dockerfile.stage file
There was a problem hiding this comment.
also APP_ENV added in prod build by @fersan1985
germanurrus
requested review from
fersan1985
and removed request for
germanurrus
|
@dbslone updates done, this is ready for new review now |
sarahy-Dapper
left a comment
sarahy-Dapper
left a comment
There was a problem hiding this comment.
REACT_APP_APP_ENV env variable is working as expected for development and production.
germanurrus
requested review from
dbslone and
germanurrus
and removed request for
dbslone
4 participants
cas-107