cas-134 Display proposal strategy name instead of icon#139
Merged
germanurrus merged 7 commits intomainfrom Jul 18, 2022
Merged
Conversation
dbslone
approved these changes
Jul 12, 2022
germanurrus
suggested changes
Jul 13, 2022
| <div className="pr-2" key={`${st}-${index}`}> | ||
| <StrategyIcon className="cursor-pointer" /> | ||
| {st.name} | ||
| </div> |
Contributor
There was a problem hiding this comment.
Proposal will be using only one strategy for winner calculation, so maybe instead of using the map we could get the first element and show it instead of mapping
const [strategy] = strategies ?? [ { name: ''}];
Also use Strategy word instead of Strategies bc for now there will be only one.
Contributor
Author
There was a problem hiding this comment.
Waiting confirmation from Jose on requirements.
germanurrus
reviewed
Jul 18, 2022
germanurrus
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed icon to text
