Skip to content

remove duplicated migration files#141

Merged
germanurrus merged 1 commit intomainfrom
fix-migration-dup
Jul 13, 2022
Merged

remove duplicated migration files#141
germanurrus merged 1 commit intomainfrom
fix-migration-dup

Conversation

@germanurrus
Copy link
Copy Markdown
Contributor

@germanurrus germanurrus commented Jul 13, 2022 •
edited
Loading

removes duplicated migration file:
error: duplicate migration file: 000021_add_balance_of_nfts.down.sql

germanurrus
germanurrus commented Jul 13, 2022
View reviewed changes
Comment thread backend/migrations/000021_add_achievements_details_column.down.sql
@@ -1,3 +0,0 @@
ALTER TABLE user_achievements RENAME TO community_users_achievements;
ALTER TABLE community_users_achievements DROP COLUMN details;

Copy link
Copy Markdown
Contributor Author

@germanurrus germanurrus Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of https://github.com/DapperCollectives/CAST/blob/375d108e3ef2b3cd0d11b2d8772ad295e8e6f6bf/backend/migrations/000020_add_achievements_details_column.down.sql#L0-L1

germanurrus
germanurrus commented Jul 13, 2022
View reviewed changes
Comment thread backend/migrations/000021_add_achievements_details_column.up.sql
@@ -1,3 +0,0 @@
ALTER TABLE community_users_achievements ADD details VARCHAR NOT NULL;
ALTER TABLE community_users_achievements ADD UNIQUE (details);
ALTER TABLE community_users_achievements RENAME TO user_achievements; No newline at end of file
Copy link
Copy Markdown
Contributor Author

@germanurrus germanurrus Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup of https://github.com/DapperCollectives/CAST/blob/375d108e3ef2b3cd0d11b2d8772ad295e8e6f6bf/backend/migrations/000020_add_achievements_details_column.up.sql#L0-L1

@germanurrus germanurrus marked this pull request as ready for review July 13, 2022 14:05
@germanurrus germanurrus merged commit 9fa9d62 into main Jul 13, 2022
@germanurrus germanurrus deleted the fix-migration-dup branch July 13, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbslone dbslone Awaiting requested review from dbslone

@jacksonConrad jacksonConrad Awaiting requested review from jacksonConrad

1 more reviewer

@0xmovses 0xmovses 0xmovses approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@germanurrus @0xmovses