CAS-103 - fix join button position#145
Merged
germanurrus merged 3 commits intomainfrom Jul 14, 2022
Merged
Conversation
germanurrus
commented
Jul 14, 2022
| const leaveCommunity = async () => { | ||
| const leaveCommunity = async (event) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); |
Contributor
Author
There was a problem hiding this comment.
added this to prevent navigation from the community card to the community when clicking on join community in the home page
Contributor
There was a problem hiding this comment.
With the style changes, I agree that this is a better way than having it positioned absolute.
germanurrus
commented
Jul 14, 2022
Comment on lines
+13
to
14
| maxHeight: '3rem', | ||
| overflow: 'hidden', |
Contributor
Author
There was a problem hiding this comment.
this is preventing the card panel to have extra height if body payload is too long, this might need some changes if we don't want to hide longer texts
Contributor
There was a problem hiding this comment.
Maybe we could do something similar to the ProposalCard for clamping the text?
CJamesKeller
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied style fixes for join community button, also avatar size was changed on mobile and some styling on community card based on CAS-103 feedback.
Before:
After:
