community page layout improvements#148
Merged
mannynotfound merged 7 commits intomainfrom Jul 18, 2022
Merged
Conversation
mannynotfound
force-pushed
the
manny/cas-190
branch
from
4b5c610 to
6c7e7e9
Compare
germanurrus
reviewed
Jul 14, 2022
| > | ||
| Links | ||
| </div> | ||
| <Title>Links</Title> |
Contributor
There was a problem hiding this comment.
this one need classes column is-12 should Title allow classNames prop like classNames={"column is-12"}
mannynotfound
force-pushed
the
manny/cas-190
branch
from
6c7e7e9 to
bc4983d
Compare
Contributor
Author
|
@germanurrus updated to allow |
germanurrus
reviewed
Jul 15, 2022
mannynotfound
force-pushed
the
manny/cas-190
branch
from
86a958f to
6d76d41
Compare
mannynotfound
force-pushed
the
manny/cas-190
branch
from
6d76d41 to
ef566d2
Compare
Contributor
Author
|
@germanurrus should be g2g now |
germanurrus
reviewed
Jul 18, 2022
Contributor
germanurrus
left a comment
germanurrus
left a comment
There was a problem hiding this comment.
Looks good! just left a comment
| @@ -0,0 +1,11 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const Title = ({ children, className }) => ( | |||
Contributor
There was a problem hiding this comment.
could to make className to default to ''
const Title = ({ children, className = '' } = {}) => (
so on the class prop it does not get undefined:
germanurrus
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Titlecomponent for community tabs(grid ruler lines not part of changes, just shown for visual reference)
