CAS-248 - add error message for in-line image#178
Merged
germanurrus merged 3 commits intomainfrom Jul 18, 2022
Merged
Conversation
germanurrus
commented
Jul 18, 2022
| onDismiss, | ||
| isCancelling = false, | ||
| onDone, | ||
| maxImageFiles = MAX_IMAGE_FILES, |
Contributor
Author
There was a problem hiding this comment.
made this a prop for the component
germanurrus
commented
Jul 18, 2022
| export const MAX_AVATAR_FILE_SIZE = 2097152; | ||
|
|
||
| export const MAX_PROPOSAL_IMAGE_FILE_SIZE = 2097152; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this is kind of repeated but applies only for in-line images updated to proposals
germanurrus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Error Message on upload:
Not Related but fixes style on mobile:
Before:
After:
