Conversation
jbluks
requested review from
0xmovses,
dbslone and
germanurrus
and removed request for
germanurrus
Contributor
|
Holding this one off from merged till after Launch. |
dbslone
approved these changes
Jul 22, 2022
dbslone
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Revert "take snapshot for one-address-one-vote-ft strat (#282)" This reverts commit 050055f. * Revert "CAS-204: Add NFT/FT restrictions to One Address One Vote strategy (#218)" This reverts commit 4866348. * update order of migration files * remove one adderess one vote migrations * fixes migrations so migrating up/down should work smoothly, and production migration will not fail * fetch NFT vote weight during createVote properly * fixes SQL for fetching votes w/ balances on proposals that don't reference block_height (i.e. NFT strategies)
dbslone
added a commit
that referenced
this pull request
Jul 26, 2022
* Revert "take snapshot for one-address-one-vote-ft strat (#282)" This reverts commit 050055f. * Revert "CAS-204: Add NFT/FT restrictions to One Address One Vote strategy (#218)" This reverts commit 4866348. * update order of migration files * remove one adderess one vote migrations * fixes migrations so migrating up/down should work smoothly, and production migration will not fail * fetch NFT vote weight during createVote properly * fixes SQL for fetching votes w/ balances on proposals that don't reference block_height (i.e. NFT strategies) * shows vote weight in Votes list instead of balance (weight is more general) Co-authored-by: David Slone <dbslone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CAS-204
Description
one-address-one-vote-nftandone-address-one-vote-ft