Skip to content

fix strategy update on community creation #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
germanurrus merged 3 commits into from
Jul 25, 2022
Merged

fix strategy update on community creation #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75816f6
fix stategy
germanurrus Jul 25, 2022
accc15a
Merge branch 'main' into enable-to-delete-strategy
germanurrus Jul 25, 2022
1e673b0
update prop
germanurrus Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/packages/client/src/components/Community/StrategySelectorForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default function StrategySelectorForm({
callToAction = () => {},
// callback to return strategies selected
onStrategySelection,
enableDelUniqueItem,
} = {}) {
// holds array of objects with strategy information
const [strategies, setStrategies] = useState(existingStrategies);
Expand Down Expand Up @@ -58,8 +59,8 @@ export default function StrategySelectorForm({
setStrategies((state) => state.filter((_, idx) => idx !== index));
};

// hide delete when there's only one strategy
const enableDelete = strategies.length > 1;
// hide delete when there's only one strategy unless passed by prop
const enableDelete = enableDelUniqueItem ?? strategies.length > 1;

const callToActionComponent = callToAction(strategies);

Expand Down
1 change: 1 addition & 0 deletions frontend/packages/client/src/components/CommunityCreate/StepFour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default function StepFour({
<StrategySelectorForm
existingStrategies={strategies}
onStrategySelection={onStrategySelection}
enableDelUniqueItem
callToAction={() => {
return (
<ActionButton
Expand Down
4 changes: 2 additions & 2 deletions frontend/packages/client/src/pages/CommunityEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ export default function CommunityEditorPage() {
// initial loading
if (loading && !community) {
return (
<section className="section">
<div className="container is-flex full-height">
<section className="section full-height">
<div className="container is-flex full-height is-justify-content-center">
<Loader fullHeight />
</div>
</section>
Expand Down