CAS-367 - Update to use react-query#362
Merged
germanurrus merged 98 commits intomainfrom Sep 12, 2022
Merged
Conversation
germanurrus
changed the title
germanurrus
commented
Sep 9, 2022
| maxWeight: '2222', | ||
| publicPath: 'flowTokenBalance', | ||
| } | ||
| : undefined), |
Contributor
Author
There was a problem hiding this comment.
added this logic to have some data to test easier, once reviewed will be removed. Use Token-weighted
…ves/CAST into germanurrustarazu/cas-367
jbluks
requested changes
Sep 9, 2022
| const message = `${proposal.id}:${hexChoice}:${timestamp}`; | ||
| const hexMessage = Buffer.from(message).toString('hex'); | ||
|
|
||
| const [compositeSignatures, voucher] = await signMessageByWalletProvider( |
Collaborator
There was a problem hiding this comment.
Can we move this into a function in our api directory?
Contributor
Author
There was a problem hiding this comment.
created voteOnProposalApiReq fn but I think as a general approach we could leave signing the request in the react-query definition, otherwise we need to pass to the function the signMessageByWalletProvider and the user since they come from a hook they can't be included in a regular function because of hook restrictions
jbluks
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please test all the user actions that will make GET, POST, PATCH and DELETE requests.