Skip to content

CAS-440 - Add hook form to proposal creation#379

Merged
germanurrus merged 38 commits intomainfrom
germanurrustarazu/cas-440
Aug 31, 2022
Merged

CAS-440 - Add hook form to proposal creation#379
germanurrus merged 38 commits intomainfrom
germanurrustarazu/cas-440

Conversation

@germanurrus
Copy link
Copy Markdown
Contributor

@germanurrus germanurrus commented Aug 19, 2022

  • Adds react-hook-forms to create proposals
  • Adds refactor to components to add react-hook-forms

Error messages on first step:
Screen Shot 2022-08-31 at 11 53 42

Error messages on options:
Screen Shot 2022-08-31 at 11 53 50

Screen Shot 2022-08-31 at 11 53 58

Screen Shot 2022-08-31 at 11 59 18

Error messages on Strategy:
Screen Shot 2022-08-31 at 12 13 35

Screen Shot 2022-08-31 at 12 13 26

Error messages on Dates:
Screen Shot 2022-08-31 at 11 59 44

@linear
Copy link
Copy Markdown

linear Bot commented Aug 19, 2022

CAS-440

@germanurrus germanurrus marked this pull request as ready for review August 31, 2022 15:14
@germanurrus germanurrus requested review from dbslone, jbluks and sarahy-Dapper and removed request for dbslone August 31, 2022 15:14
// TODO: make enter to jump to next input field on form
const checkKeyDown = (e) => {
if (e.code === 'Enter') e.preventDefault();
};
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents enter to open dropdown components to open on forms with dropdown

@germanurrus germanurrus merged commit 2105bd7 into main Aug 31, 2022
@germanurrus germanurrus deleted the germanurrustarazu/cas-440 branch August 31, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants