Skip to content

CAS-455 - Connect Wallet V2#427

Merged
germanurrus merged 15 commits intomainfrom
germanurrustarazu/cas-455
Sep 6, 2022
Merged

CAS-455 - Connect Wallet V2#427
germanurrus merged 15 commits intomainfrom
germanurrustarazu/cas-455

Conversation

@germanurrus
Copy link
Copy Markdown
Contributor

@germanurrus germanurrus commented Sep 1, 2022

Connect button:
Screen Shot 2022-09-06 at 09 26 11
On Connected status:
Screen Shot 2022-09-06 at 09 26 22
Screen Shot 2022-09-06 at 09 26 34

On Click on button:
Screen Shot 2022-09-05 at 19 20 00

On click on copied:
Screen Shot 2022-09-06 at 09 27 09
Screen Shot 2022-09-06 at 09 27 52

@linear
Copy link
Copy Markdown

linear Bot commented Sep 1, 2022

CAS-455

@germanurrus germanurrus marked this pull request as ready for review September 6, 2022 12:38
</div>
</div>
</div>
</>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a upcoming update for this component, I thought about making it more modular but decided to wait for the update and see how it can be split into more components

alwaysVisible ? ' has-tooltip-active' : ''
}`;

const props = enabled ? { 'data-tooltip': text } : {};
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by removing data-tooltip' tooltip gets disabled

Copy link
Copy Markdown
Collaborator

@jbluks jbluks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germanurrus germanurrus merged commit 4897d09 into main Sep 6, 2022
@germanurrus germanurrus deleted the germanurrustarazu/cas-455 branch September 6, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants