cas 484 - Create search endpoint for Communities#433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• creates new endpoint
/communities/search/{query}• creates new controller, helper and models method.
• adds new migrations that install the extensions and indexing needed
I used the examples laid out here https://arctype.com/blog/postgres-fuzzy-search/#phonetic-match I had mixed results with all of them, the query that seemed to perform best is the one in this PR:
SELECT name FROM communities WHERE SIMILARITY(name, $1) > 0.1,For the front end we might need to use url encoding on the param, for example if search query has a space in it like
nba topshotsJust tested with Postman. No integration tests written for this feature