Skip to content

update global styles / classes#435

Merged
mannynotfound merged 2 commits intomainfrom
manny/cas-480
Sep 12, 2022
Merged

update global styles / classes#435
mannynotfound merged 2 commits intomainfrom
manny/cas-480

Conversation

@mannynotfound
Copy link
Copy Markdown
Contributor

  • remove Arimo/Roboto/Helvetica, make DM Sans the primary font for everything
  • refactor color variables, remove unused variables and add "success" and "danger" color for success/error messages
  • switch any gray classes to grey as Bulma uses grey convention, refactor grey classes to be simpler
  • update some of our grey shades
  • remove $red and .has-text-red as we were using it exclusively for error messages, which in that case we should actually use Bulma's $danger and has-text-danger

image

@linear
Copy link
Copy Markdown

linear Bot commented Sep 8, 2022

CAS-480

Copy link
Copy Markdown
Contributor

@germanurrus germanurrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<WrapperResponsive
as="h2"
classNames="title mt-5 is-4 has-text-back has-text-weight-normal"
classNames="title mt-5 is-4 has-text-black has-text-weight-normal"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

$family-monospace: "Roboto Mono"
$title-family: $family-secondary
$family-sans-serif: "DM Sans"
$family-monospace: "DM Sans"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this class also needs to be updated:

.image-caption-draft-js
	.public-DraftStyleDefault-block.public-DraftStyleDefault-ltr
		margin: 0px !important
		font-family: 'Arimo'
		font-style: normal
		font-weight: 400
		font-size: 12px
		line-height: 140%
		color: #757575

maybe remove the font-family: 'Arimo'

@mannynotfound mannynotfound merged commit 3e29b40 into main Sep 12, 2022
@mannynotfound mannynotfound deleted the manny/cas-480 branch September 12, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants