Fix provider icon on wallet list#451
Merged
germanurrus merged 7 commits intoDapperCollectives:mainfrom Sep 14, 2022
Merged
Conversation
Discovery had a bug that was returning relative paths. Now you can just use provider.icon as the src.
chasefleming
changed the title
germanurrus
reviewed
Sep 14, 2022
| } | ||
| return `https://fcl-discovery.onflow.org${provider.icon}`; | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
I think we still need this function when REACT_APP_FLOW_ENV=emulator because icons are not returning absolute paths on provider.icon
germanurrus
reviewed
Sep 14, 2022
| ); | ||
| closeModal(); | ||
| }, | ||
| icon: getWalletIcon(service.provider), |
Contributor
There was a problem hiding this comment.
maybe doing this:
icon: IS_LOCAL_DEV
? getWalletIcon(service.provider)
: service.provider.icon,
Contributor
Author
There was a problem hiding this comment.
Ok updated @germanurrus . Just out of curiosity, why is it like that on local dev instead of just using the Discovery API with testnet services?
Contributor
There was a problem hiding this comment.
We are developing in local dev using emulator for connecting wallets, this way we can deploy contracts to a controlled env that gives us more flexibility to develop
This reverts commit f57c563.
germanurrus
approved these changes
Sep 14, 2022
germanurrus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery had an issue that was returning relative paths. Now you can just use provider.icon as the src.
Addresses: #452